test: make error reporting system test more robust #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were comparing the list of services using the representative sample. This means that if more than one service have the same error, we may not necessarily get the sample that we want to observe. Instead look for all the affected services for all groups to find the matching group. Ref: googleapis/nodejs-logging-winston#279
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 2 2
Lines 78 78
Branches 8 8
=======================================
Hits 74 74
Misses 4 4Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were comparing the list of services using the
representative sample. This means that if more than one service have the
same error, we may not necessarily get the sample that we want to
observe. Instead look for all the affected services for all groups to
find the matching group.
Ref: googleapis/nodejs-logging-winston#279