This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Floating promise lint error fixes#2400
Merged
MarkDuckworth merged 7 commits intonode-18from Aug 22, 2025
Merged
Conversation
This PR fixes all the floating promise errors in the test files. It also converts all the `then` calls to `async/await` in the test files.
…anged the meaning of the test.
ehsannas
reviewed
Aug 18, 2025
Contributor
ehsannas
left a comment
There was a problem hiding this comment.
Overall great. There were a few (below) that were hard to reason about.
ehsannas
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jules collab to fix >450 floating promise errors identified by gts. Jules provided refactor of many promise chains into async-await code.