This repository was archived by the owner on Mar 4, 2026. It is now read-only.
fix!: Update WithFieldData and PartialWithFieldData to ignore methods on types#2294
Merged
MarkDuckworth merged 9 commits intomainfrom Oct 29, 2025
Merged
Conversation
…b.com:googleapis/nodejs-firestore into markduckworth/withfieldvalue-ignore-functions
milaGGL
reviewed
Apr 9, 2025
|
Does this affect googleapis/google-cloud-node#7464 at all? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #2291 - Will not affect methods on types passed to WithFieldData and PartialWithFieldData.
This has some potential to be a breaking change, so I have marked it as such. To be safe, I will include it in the next major version release.