fix: emulator support for system tests#1813
Conversation
|
Run system tests against the emulator using: |
Are you able to add these to the github actions CI? |
|
@dconeybe I created a separate task to modify the CI for running system tests against the emulator. See, b/266735404 |
…ing error messages.
dconeybe
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding emulator support! It was annoying when I was working on COUNT (in the java-firestore sdk) that some tests would fail against the emulator. I just ended up ignoring those failures but it's better to have each such failure explicitly marked as not being supported in the firestore emulator. This will definitely be a benefit to future work on this sdk.
Can you add this information to the PR's description? That will make it much more discoverable. |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
fix: emulator support for system tests. Run system tests against the emulator using:
yarn system-test:grpc:emulatororyarn system-test:rest:emulatorBEGIN_COMMIT_OVERRIDE
fix: emulator support for system tests. Run system tests against the emulator using:
yarn system-test:grpc:emulatororyarn system-test:rest:emulatorEND_COMMIT_OVERRIDE