Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

fix: prevent crashes if an inactive stream receives an error.#2283

Merged
wu-hui merged 2 commits intomainfrom
ehsann/handle-error-after-end
Jan 21, 2025
Merged

fix: prevent crashes if an inactive stream receives an error.#2283
wu-hui merged 2 commits intomainfrom
ehsann/handle-error-after-end

Conversation

@ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jan 13, 2025

No description provided.

@ehsannas ehsannas requested review from a team as code owners January 13, 2025 23:21
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 13, 2025
@ehsannas ehsannas self-assigned this Jan 13, 2025
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Jan 13, 2025
@ehsannas ehsannas mentioned this pull request Jan 13, 2025
Closed
@ehsannas ehsannas requested a review from wu-hui January 21, 2025 17:57
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Jan 21, 2025
@ehsannas
Copy link
Contributor Author

ehsannas commented Jan 21, 2025

Fixes #2280

@wu-hui wu-hui merged commit f58fe79 into main Jan 21, 2025
15 checks passed
@wu-hui wu-hui deleted the ehsann/handle-error-after-end branch January 21, 2025 22:36
@release-please release-please bot mentioned this pull request Jan 21, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wu-hui wu-hui wu-hui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wu-hui wu-hui

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ehsannas @wu-hui