Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: Support for index signatures in UpdateData<T>#1953

Merged
MarkDuckworth merged 10 commits intomainfrom
markduckworth/update-data-index-signatures
Oct 29, 2025
Merged

feat: Support for index signatures in UpdateData<T>#1953
MarkDuckworth merged 10 commits intomainfrom
markduckworth/update-data-index-signatures

Conversation

@MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Dec 6, 2023

Port with additional fixes: firebase/firebase-js-sdk#7318

Fixes b/311751201 🦕
Fixes b/315204283

@MarkDuckworth MarkDuckworth requested review from a team as code owners December 6, 2023 21:30
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Dec 6, 2023
tom-andersen
tom-andersen previously approved these changes Dec 19, 2023
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkDuckworth MarkDuckworth added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 10, 2024
@MarkDuckworth MarkDuckworth added next major: breaking change this is a change that we should wait to bundle into the next major version kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 29, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2025
@MarkDuckworth MarkDuckworth merged commit afa206d into main Oct 29, 2025
21 of 22 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/update-data-index-signatures branch October 29, 2025 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/nodejs-firestore API. next major: breaking change this is a change that we should wait to bundle into the next major version size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants