-
Notifications
You must be signed in to change notification settings - Fork 29
Closed
Labels
🚨This issue needs some love.This issue needs some love.api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.Issues related to the googleapis/nodejs-error-reporting API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
If you are still having issues, please be sure to include as much information as
possible:
Environment details
- OS: Mac/Linux
- Node.js version: 8.11.4
- npm version: 6.4.0
- @google-cloud/error-reporting version: 0.5.1
- hapi version: 16.x (<- probably the most important one :D)
Steps to reproduce
This is due to
| .setUrl(req!.url as {} as string) |
req.url can be an URL object. I would suggest to fallback to req.path or req.url.path.If that sounds ok I can do a PR if you'd like
Following these steps will guarantee the quickest resolution possible.
Thanks!
Metadata
Metadata
Assignees
Labels
🚨This issue needs some love.This issue needs some love.api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.Issues related to the googleapis/nodejs-error-reporting API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
