Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

feat: generate client library with supporting paging #589

Merged
summer-ji-eng merged 5 commits into from
Jul 30, 2021
Merged

feat: generate client library with supporting paging #589

summer-ji-eng merged 5 commits into from
Jul 30, 2021

Conversation

@summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Jul 30, 2021 •
edited
Loading

Duplicate name IPProtocol in protos/proto.json, replace to IIProtocol_ in googleapis-discovery/google/cloud/compute/v1/compute.proto

use latest typescript generator

-_gapic_generator_typescript_version = "1.5.0"
+_gapic_generator_typescript_version = "2.1.1"
 
-_gapic_generator_typescript_sha256 = "17e9387f3d6da8e5382b4e138ccc401137d2938b394040984ef2ca11ff9f8aea"
+_gapic_generator_typescript_sha256 = "c4117fedcd726c14af8c6a70c810b25a6bdf2523b43a867bafdf6478c0ac745a"

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner July 30, 2021 07:42
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2021
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/nodejs-compute API. label Jul 30, 2021
@generated-files-bot
Copy link

generated-files-bot bot commented Jul 30, 2021

Warning: This pull request is touching the following templated files:

  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@snippet-bot
Copy link

snippet-bot bot commented Jul 30, 2021 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@summer-ji-eng summer-ji-eng requested a review from bcoe July 30, 2021 18:01
@summer-ji-eng summer-ji-eng merged commit 44e9c14 into diregapic Jul 30, 2021
@summer-ji-eng summer-ji-eng deleted the add_page branch July 30, 2021 23:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bcoe bcoe Awaiting requested review from bcoe

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

1 more reviewer

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: compute Issues related to the googleapis/nodejs-compute API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@summer-ji-eng @bcoe @sofisl