test: add test for close()#992
Merged
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom Jan 21, 2022
Merged
Conversation
We are going to return `this` in the function changed which shouldn't have any side effects since we wouldn't have been doing anything with void anyway.
This reverts commit 39aacaa.
mutianf
reviewed
Jan 20, 2022
test/index.ts
Outdated
| done(); | ||
| } else { | ||
| assert.fail( | ||
| 'The request did not fail, but it should have because the connection closed' |
Contributor
There was a problem hiding this comment.
nit: because the connection is closed
mutianf
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a test case for the new close function