Conversation
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
========================================
Coverage 99.22% 99.23%
========================================
Files 18 18
Lines 17416 17539 +123
Branches 1025 977 -48
========================================
+ Hits 17281 17404 +123
Misses 132 132
Partials 3 3
Continue to review full report at Codecov.
|
|
I believe this code is good to merge. @tmatsuo Please review. |
| for version in ['v2']: | ||
| library = staging / version | ||
| _tracked_paths.add(library) | ||
| s.copy([library], excludes=['package.json', 'README.md', 'src/index.ts', 'src/v2/index.ts', 'tsconfig.json', 'tslint.json']) | ||
|
|
||
| # Copy the admin library. | ||
| # Not override system-test for admin/v2, just keep the v2 version. | ||
| for version in ['v2']: | ||
| library = staging / 'admin' / version | ||
| _tracked_paths.add(library) | ||
| s.copy([library], excludes=['package.json', 'README.md', 'src/index.ts', 'src/v2/index.ts', 'tsconfig.json', 'tslint.json', 'system-test/fixtures/sample/src/index.ts', 'system-test/fixtures/sample/src/index.js']) |
There was a problem hiding this comment.
nit: these could be in the same loop
There was a problem hiding this comment.
Duly noted. I'm not sure that when they release v3, it will be released at exactly the same time for each library. I wanted to leave a code structure that would not require refactoring when v3 is released.
No description provided.