feat: implement restore table to a different instance feature (#830)#863
Merged
gcf-merge-on-green[bot] merged 4 commits intomasterfrom May 4, 2021
Merged
feat: implement restore table to a different instance feature (#830)#863gcf-merge-on-green[bot] merged 4 commits intomasterfrom
gcf-merge-on-green[bot] merged 4 commits intomasterfrom
Conversation
* feat: implement restore table to a different instance feature * chore: docs * chore: add system test * fix(samples): region tag * fix: docs
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Contributor
Author
|
@liubonan fyi |
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 18 18
Lines 17416 17496 +80
Branches 1025 960 -65
=======================================
+ Hits 17281 17361 +80
Misses 132 132
Partials 3 3
Continue to review full report at Codecov.
|
craiglabenz
approved these changes
Apr 30, 2021
craiglabenz
left a comment
There was a problem hiding this comment.
Lots of BigTable magic I can't say much about, but this looks good to me on a Node front.
One interesting observation around loading instances from... an Id? To get back to its name? That was a bit unclear.
crwilcox
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: implement restore table to a different instance feature
chore: docs
chore: add system test
fix(samples): region tag
fix: docs