fix(types): overload for bigtable.getInstances#579
Merged
jkwlui merged 8 commits intogoogleapis:masterfrom Dec 4, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
=======================================
Coverage 87.24% 87.24%
=======================================
Files 33 33
Lines 2046 2046
Branches 373 374 +1
=======================================
Hits 1785 1785
Misses 233 233
Partials 28 28
Continue to review full report at Codecov.
|
callmehiphop
suggested changes
Nov 14, 2019
jkwlui
approved these changes
Nov 20, 2019
jkwlui
approved these changes
Nov 20, 2019
Member
jkwlui
left a comment
There was a problem hiding this comment.
Types look good. Approved pending changes @callmehiphop suggested
callmehiphop
approved these changes
Nov 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While accessing
bigtable.getInstanceswithasyncfunction, it is giving error of return type.Added overload and related document changes.
Fixes #564