Skip to content

fix: Prevent error when decode: false option is set in createReadStream.#403

Merged
JustinBeckwith merged 8 commits intogoogleapis:masterfrom
zrosenbauer:bugfix/createreadstream-error
Jan 30, 2019
Merged

fix: Prevent error when decode: false option is set in createReadStream.#403
JustinBeckwith merged 8 commits intogoogleapis:masterfrom
zrosenbauer:bugfix/createreadstream-error

Conversation

@zrosenbauer
Copy link
Contributor

Prevent error when decode: false option is set in createReadStream.

Fixes #394

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 20, 2019
@zrosenbauer
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 20, 2019
@JustinBeckwith JustinBeckwith changed the title Prevent error when decode: false option is set in createReadStream. fix: Prevent error when decode: false option is set in createReadStream. Jan 24, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2019
@JustinBeckwith
Copy link
Contributor

@sduskis who's the best person to review bigtable PRs for nodejs?

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 26, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 26, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2019
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 30, 2019
@JustinBeckwith JustinBeckwith merged commit 2294877 into googleapis:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants