refactor: modernize the samples a bit#398
Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom Jan 3, 2019
JustinBeckwith:sad
Merged
refactor: modernize the samples a bit#398JustinBeckwith merged 1 commit intogoogleapis:masterfrom JustinBeckwith:sad
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:sad
Conversation
sduskis
reviewed
Jan 2, 2019
| "scripts": { | ||
| "doctoc": "doctoc README.md */README.md", | ||
| "test": "mocha system-test/*.test.js --timeout=600000" | ||
| "test": "mocha system-test --timeout=60000" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sduskis
approved these changes
Jan 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this was bad. None of the tests in the
document_snippetdirectory were actually getting run, so 100% of the samples are untested. The sample tests are also all broken. As a first step, I'm moving files around and updating a few things to get us in a better position to actually get all of the tests passing.