Conversation
|
@muraliQlogic: The requirement is to have a check that requires a family with a qualifier. The qualifier could be the empty string. This PR doesn't look right. |
sduskis
left a comment
There was a problem hiding this comment.
Please add a test to ensure that an empty qualifier passes the chunk transformer. Please revert everything else.
|
fam":"" is fine, but "fam":[null] is not ok. I believe the if statement checks for "fam":[null] rather than "fam":"". We should add a unit test to confirm that. @muraliQlogic, can you please change the the chunktransformer.js test for those requirements? |
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 10
Lines ? 1287
Branches ? 0
=======================================
Hits ? 1287
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
|
@sduskis : I modified if condition to check for null or undefined qualifier. |
|
@muraliQlogic: Does |
Fixes #343