Clean up the "hello world" code sample#328
Merged
sduskis merged 3 commits intogoogleapis:masterfrom Oct 21, 2018
hegemonic:hello-world-cleanup
Merged
Clean up the "hello world" code sample#328sduskis merged 3 commits intogoogleapis:masterfrom hegemonic:hello-world-cleanup
sduskis merged 3 commits intogoogleapis:masterfrom
hegemonic:hello-world-cleanup
Conversation
Changes to code: + Add region tags for including code in docs + Change `require()` call for consistency with the API docs; the sample now requires the library as `Bigtable` and creates an instance of it by calling `new Bigtable()` + Add comments about shortcuts that would cause performance issues in production + Fix misspelled variable Changes to `README`: + Fix branding issues + Update auth instructions to use the current best practice; `gcloud auth application-default login` is no longer recommended + Update links to the GCP Console + Remove embedded screenshot from the docs, to prevent a broken image if that screenshot goes away + Miscellaneous changes for clarity and consistency
sduskis
approved these changes
Oct 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to code:
require()call for consistency with the API docs; the sample now requires the library asBigtableand creates an instance of it by callingnew Bigtable()Changes to
README:gcloud auth application-default loginis no longer recommendedFixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)