Skip to content

Fix docs and regenerate scaffolding.#3

Merged
stephenplusplus merged 1 commit intorepo-migrationfrom
jsdoc-fixes
Oct 31, 2017
Merged

Fix docs and regenerate scaffolding.#3
stephenplusplus merged 1 commit intorepo-migrationfrom
jsdoc-fixes

Conversation

@jmdobry
Copy link
Contributor

@jmdobry jmdobry commented Oct 30, 2017

No description provided.

@jmdobry jmdobry self-assigned this Oct 30, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2017
@stephenplusplus
Copy link
Contributor

Some errors popped up during ci/circleci: docs (https://circleci.com/gh/googleapis/nodejs-bigtable/22):

#!/bin/bash -eo pipefail
npm run docs

> @google-cloud/bigtable@0.10.2 docs /root/project
> repo-tools exec -- jsdoc -c .jsdoc.js

exec: Executing in: /root/project
exec: Running: jsdoc -c .jsdoc.js
Parsing /root/project/src/cluster.js ...
Parsing /root/project/src/family.js ...
Parsing /root/project/src/filter.js ...
WARNING: The @private tag does not permit a value; the value will be ignored. File: filter.js, line: 118
WARNING: The @private tag does not permit a value; the value will be ignored. File: filter.js, line: 153
WARNING: The @private tag does not permit a value; the value will be ignored. File: filter.js, line: 757
WARNING: The @private tag does not permit a value; the value will be ignored. File: filter.js, line: 762
Parsing /root/project/src/index.js ...
Parsing /root/project/src/instance.js ...
Parsing /root/project/src/mutation.js ...
Parsing /root/project/src/row.js ...
ERROR: Unable to parse a tag's type expression for source file /root/project/src/row.js in line 392 with tag title "param" and text "{object[]=} onNoMatch A list of entries to be ran if no matches are
    found.": Invalid type expression "object[]=": Expected "!" or "?" but end of input found.
ERROR: Unable to parse a tag's type expression for source file /root/project/src/row.js in line 450 with tag title "param" and text "{object[]=} onNoMatch A list of entries to be ran if no matches are
    found.": Invalid type expression "object[]=": Expected "!" or "?" but end of input found.
ERROR: Unable to parse a tag's type expression for source file /root/project/src/row.js in line 565 with tag title "param" and text "{string[]=} columns List of specific columns to retrieve.": Invalid type expression "string[]=": Expected "!" or "?" but end of input found.
ERROR: Unable to parse a tag's type expression for source file /root/project/src/row.js in line 607 with tag title "param" and text "{string[]=} columns List of specific columns to retrieve.": Invalid type expression "string[]=": Expected "!" or "?" but end of input found.
Parsing /root/project/src/table.js ...
Generating output files...
Finished running in 0.98 seconds.
exec: Oh no! Execution failed after 1.07s.

@jmdobry
Copy link
Contributor Author

jmdobry commented Oct 31, 2017

Fixed.

@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #3 into repo-migration will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           repo-migration     #3   +/-   ##
=============================================
  Coverage             100%   100%           
=============================================
  Files                   8      8           
  Lines                 789    791    +2     
=============================================
+ Hits                  789    791    +2
Impacted Files Coverage Δ
src/family.js 100% <ø> (ø) ⬆️
src/mutation.js 100% <ø> (ø) ⬆️
src/instance.js 100% <ø> (ø) ⬆️
src/filter.js 100% <ø> (ø) ⬆️
src/row.js 100% <ø> (ø) ⬆️
src/cluster.js 100% <ø> (ø) ⬆️
src/table.js 100% <ø> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e0f30...a4f69b5. Read the comment docs.

@stephenplusplus stephenplusplus merged commit 39eb034 into repo-migration Oct 31, 2017
@stephenplusplus stephenplusplus deleted the jsdoc-fixes branch October 31, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants