Skip to content

Added @example tags to src/instance.js (#222)#252

Merged
sduskis merged 2 commits intomasterfrom
docs_test
Jul 24, 2018
Merged

Added @example tags to src/instance.js (#222)#252
sduskis merged 2 commits intomasterfrom
docs_test

Conversation

@sduskis
Copy link
Contributor

@sduskis sduskis commented Jul 23, 2018 •
edited
Loading

This change was verified thanks to @jmdobry's help with generating the docs.

@vijay-qlogic @sduskis
Added @example tags to src/instance.js (#222)
df2b0c6 
* Added @example tags

* added result log

* moved instance-snippets to document-snippets/instance

* reference updated

* added code-review change requests

* Added Test Cases to check for NO-Error in instance-snippets
@sduskis sduskis requested a review from stephenplusplus July 23, 2018 16:36
@googlebot
Copy link

googlebot commented Jul 23, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@ghost ghost assigned sduskis Jul 23, 2018
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 23, 2018
@sduskis sduskis added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 23, 2018
@googlebot
Copy link

googlebot commented Jul 23, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

googlebot commented Jul 24, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 24, 2018
@codecov
Copy link

codecov bot commented Jul 24, 2018 •
edited
Loading

Codecov Report

Merging #252 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #252   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines        1266   1266           
=====================================
  Hits         1266   1266
Impacted Files Coverage Δ
src/instance.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50126a9...ab4fe13. Read the comment docs.

@sduskis sduskis added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 24, 2018
@googlebot
Copy link

googlebot commented Jul 24, 2018

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@sduskis sduskis merged commit 4bfd84e into master Jul 24, 2018
@sduskis sduskis deleted the docs_test branch July 25, 2018 21:03
@snyk-bot snyk-bot mentioned this pull request Mar 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephenplusplus stephenplusplus stephenplusplus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sduskis sduskis

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sduskis @googlebot @stephenplusplus @vijay-qlogic