test: Better factoring and generate instance id for close test#1675
Merged
gcf-merge-on-green[bot] merged 3 commits intomainfrom Aug 12, 2025
Merged
test: Better factoring and generate instance id for close test#1675gcf-merge-on-green[bot] merged 3 commits intomainfrom
gcf-merge-on-green[bot] merged 3 commits intomainfrom
Conversation
danieljbruce
commented
Aug 7, 2025
|
|
||
| describe('createReadStream', () => { | ||
| const INSTANCE = bigtable.instance('instance'); | ||
| const TABLE = INSTANCE.table('table'); |
Contributor
Author
There was a problem hiding this comment.
This change is just better factoring. These two variables are only used in this block so should not be mixed with the other test to create confusion.
daniel-sanche
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every once in a while the close client test acts up. It says the instance has already been created. This PR may fix this flakey test and if not at the very least it will make sure two running system tests don't interfere with one another.
Impact
Less Flakey tests
Testing
Test changed to be less Flakey