Skip to content

test: Add comments to the setup hook for the client side metrics tests#1667

Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom
add-comment-csm-tests
Aug 12, 2025
Merged

test: Add comments to the setup hook for the client side metrics tests#1667
gcf-merge-on-green[bot] merged 4 commits intomainfrom
add-comment-csm-tests

Conversation

@danieljbruce
Copy link
Contributor

Description

This change is a follow-up to https://github.com/googleapis/nodejs-bigtable/pull/1662/files where we discussed maybe a comment would be helpful for this test.

Impact

Better test readability

Testing

Just comments added

@danieljbruce danieljbruce requested a review from a team August 6, 2025 21:10
@danieljbruce danieljbruce requested a review from a team as a code owner August 6, 2025 21:10
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Aug 6, 2025
Copy link

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention why we need the second project? I think that's the part that might need more context in the future

@danieljbruce danieljbruce added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2025
@danieljbruce danieljbruce added the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 98c1064 into main Aug 12, 2025
25 of 30 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-comment-csm-tests branch August 12, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants