test: Generate a unique id for each of the instances in the client side metrics system tests#1662
Merged
danieljbruce merged 6 commits intomainfrom Aug 6, 2025
Merged
Conversation
eliminate magic string matching
…into generate-id-for-system-tests # Conflicts: # system-test/client-side-metrics-all-methods.ts
daniel-sanche
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The system tests are failing frequently with a NOT_FOUND instance error. The hypothesis is that since the client side metrics system tests are always running against the same instance name
emulator-test-instancethat one test suite is deleting this instance while the other test suite is reading from it causing this error. The solution is that like the other system tests we should generate a unique id for the created instance so that two tests suites running at the same time do not interfere with one another. We also need to add some code for the unique case where we need to create instances on a second project for theshould send the metrics to the metrics handler for a single row readtest.Impact
Less Flakey tests
Testing
Tests changed to use a unique instance id each time for client side metrics.