feat: add support for Execute Query#1613
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
Docs check is failing because of a couple lingering references to the internal repo:
Conformance tests look to have a lot of real failures though |
| }; | ||
|
|
||
| const parameterTypes = { | ||
| row_key: Bigtable.ExecuteQueryTypes.String(), |
There was a problem hiding this comment.
This needs to be SqlTypes now and it needs to be a separate import, it's not namespaced under Bigtable
|
|
||
| instance | ||
| .prepareStatement(prepareStatementOptions) | ||
| .then(preparedStatement => |
There was a problem hiding this comment.
this should be then([preparedStatement] => ...
Since we wrap PreparedStatement in PreparedSTatement response
|
Warning: This pull request is touching the following templated files:
|
.github/workflows/ci.yaml
Outdated
| - uses: JustinBeckwith/linkinator-action@v1 | ||
| with: | ||
| paths: docs/ | ||
| concurrency: 1 |
There was a problem hiding this comment.
There's a build warning saying this shouldn't be edited directly, can we remove it?
There was a problem hiding this comment.
ah, I pushed more than I meant to, sorry about that. These were my attempts to fix the CI, I removed them.
jackdingilian
left a comment
There was a problem hiding this comment.
LGTM. Docs check seems flaky, I will keep re-running it until it passes
Description
This PR adds support for two new methods
executeQueryandprepareStatementin the Node.js Bigtable client library. TheprepareStatementmethod allows the users to create SQL-like queries which can then be executed on Bigtable tables.Impact
executeQueryprovides a simpler alternative for users who want to retrieve filtered rows without manually building complex filter chains.Testing
Checklist