test: Fix service path system tests#1607
Merged
danieljbruce merged 2 commits intomainfrom May 28, 2025
Merged
Conversation
hongalex
approved these changes
May 28, 2025
kevkim-codes
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A fix was applied in gax here, but this fix is affecting Bigtable tests. Error messages now have more information so previous assert.strictEqual checks are failing. The solution to unblock the CI pipeline is to only check the first part of the error message for correctness as the latter part of the error message can vary.
Impact
Unblocks the CI pipeline.
Testing
Tests were changed just to check the first part of the string.