test: Add a test that confirms errors are properly passed through for getInstance calls#1606
Merged
gcf-merge-on-green[bot] merged 7 commits intomainfrom Aug 14, 2025
Merged
Conversation
feywind
previously approved these changes
May 21, 2025
test/errors.ts
Outdated
| describe('with getInstances', () => { | ||
| const emitGetInstancesError = (stream: any) => { | ||
| const metadata = new grpc.Metadata(); | ||
| metadata.set( |
Contributor
There was a problem hiding this comment.
Might add a comment here about what the magic buffer numbers mean.
Contributor
Author
There was a problem hiding this comment.
I think this was in the code snippet I copied because it is realistic to have metadata, but I just removed it because it isn't actually necessary.
cindy-peng
approved these changes
May 21, 2025
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This test confirms that errors will bubble up to the user for getInstances calls which allows us to close b/388499540 as not reproducible.
Impact
Just adding a test to confirm correct client library behaviour
Additional Information
Two files were edited: