You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
it'd be nice for the commit message to mention that this is related to the test proxy and not the implementation itself 😊 maybe prepend testproxy: to the title?
it'd be nice for the commit message to mention that this is related to the test proxy and not the implementation itself 😊 maybe prepend testproxy: to the title?
Unfortunately for the conventional commits to pass we must prefix with a specific word. Probably test: in this case.
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!
for reference, I used chore in the commit I introduced the testproxy, ref: 0b3d996
danieljbruce
changed the title
test: testproxy: Slight change in data returned by readRow
chore(testproxy): read row should return a single row
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: bigtableIssues related to the googleapis/nodejs-bigtable API.size: xsPull request size is extra small.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get one of the specific test cases passing for readRow, we need a slight fix to the way returned data is parsed.