Skip to content

feat: enable retries for RESOURCE_EXHAUSTED an simplify error codes#1070

Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
igorbernstein2:res-ex
Apr 13, 2022
Merged

feat: enable retries for RESOURCE_EXHAUSTED an simplify error codes#1070
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
igorbernstein2:res-ex

Conversation

@igorbernstein2
Copy link
Contributor

Unify retriable status codes for ReadRows and MutateRows to be DEADLINE_EXCEEDED - RESOURCE_EXHAUSTED, ABORTED, UNAVAILABLE.

Unify retriable status codes for ReadRows and MutateRows to be DEADLINE_EXCEEDED -  RESOURCE_EXHAUSTED, ABORTED, UNAVAILABLE.
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner April 13, 2022 19:01
@igorbernstein2 igorbernstein2 requested a review from a team April 13, 2022 19:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/nodejs-bigtable API. labels Apr 13, 2022
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2022
Copy link
Contributor

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not too sure why idempotent requests would retry based on a different error set before so it seems reasonable to retry based on the same set of errors no matter what type of call we make as per the changes.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 6832df7 into googleapis:main Apr 13, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2022
@igorbernstein2 igorbernstein2 deleted the res-ex branch April 13, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants