Skip to content

fix: fix retry logic in mutate and read#980

Merged
mutianf merged 4 commits intogoogleapis:mainfrom
mutianf:fix-retry
Jan 12, 2022
Merged

fix: fix retry logic in mutate and read#980
mutianf merged 4 commits intogoogleapis:mainfrom
mutianf:fix-retry

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Jan 12, 2022 •
edited
Loading

There's no 'request' event when a request is sent, so numRequestsMade is never incremented in mutate and reads which means failures will be retried forever. Increment the counter in makeNextBatchRequest and makeNewRequest instead.

@mutianf mutianf requested a review from a team January 12, 2022 16:32
@mutianf mutianf requested a review from a team as a code owner January 12, 2022 16:32
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Jan 12, 2022
@bcoe bcoe added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2022
@mutianf mutianf changed the title fix: fix retry logic in mutate fix: fix retry logic in mutate and read Jan 12, 2022
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 12, 2022
@mutianf mutianf merged commit bfa84e1 into googleapis:main Jan 12, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 12, 2022
@mutianf mutianf deleted the fix-retry branch January 12, 2022 22:53
@release-please release-please bot mentioned this pull request Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/nodejs-bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mutianf @bcoe @yoshi-kokoro