fix: In Client-side metrics makes sure that the right views get created for the right metrics#1590
Merged
danieljbruce merged 8 commits intomainfrom Jul 9, 2025
Merged
Conversation
…ed for the right metrics
…pis/nodejs-bigtable into 359913994-views-change-2
| instrumentName: name, | ||
| name, | ||
| aggregation: name.endsWith('latencies') | ||
| aggregation: !name.endsWith('latencies') |
There was a problem hiding this comment.
should there be a test verifying this?
Contributor
Author
There was a problem hiding this comment.
Sure. I don't want that to block a change to fix something we currently have in production though so I have put this in a backlog bug. Verifying the views got created is fairly non-trivial.
daniel-sanche
previously approved these changes
Jul 7, 2025
daniel-sanche
left a comment
There was a problem hiding this comment.
LGTM, but consider a test so this can't slip through in the future
daniel-sanche
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a one line fix. If the aggregation ends with 'latencies' then the explicit bucket histogram should be used, not the sum histogram and vice versa.