Skip to content

chore!: migrate to Node 18#1582

Merged
gcf-merge-on-green[bot] merged 68 commits intomainfrom
owl-bot-copy-once-again-try-the-changes-add-script-run-script
Apr 16, 2025
Merged

chore!: migrate to Node 18#1582
gcf-merge-on-green[bot] merged 68 commits intomainfrom
owl-bot-copy-once-again-try-the-changes-add-script-run-script

Conversation

@danieljbruce
Copy link
Contributor

@danieljbruce danieljbruce commented Apr 3, 2025

This PR is the PR with the fixes necessary for upgrading to Node 18.

To produce this PR I:

  • Took changes from the owl-bot-copy generator branch
  • Fixed some compiler errors
  • Ran the pre-processor
  • Fixed some more compiler errors
  • Fixed the linting issues

gcf-owl-bot bot and others added 30 commits September 11, 2024 00:06
@gcf-owl-bot
feat: Add support for Cloud Bigtable Row Affinity in App Profiles
6452d0a 
PiperOrigin-RevId: 673093969

Source-Link: googleapis/googleapis@cbf696d

Source-Link: googleapis/googleapis-gen@a2f7ec1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTJmN2VjMTE5MTgxMzMwNGIzYmQwMDk3Y2FhMzM5NTZiZGIzYjYzNyJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
1acbfcb 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
feat: Add support for Cloud Bigtable Node Scaling Factor for CBT Clus…
17248fd 
…ters

PiperOrigin-RevId: 676993928

Source-Link: googleapis/googleapis@407deca

Source-Link: googleapis/googleapis-gen@4fae779
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZhZTc3OTIwZGEwZjQ1MDNiYmY1ZjNjZTM0ZmMwN2JjZDZkM2Q5YSJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
c3d8fcb 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
feat: Add feature flags proto for Direct Access
069e1bd 
PiperOrigin-RevId: 690605789

Source-Link: googleapis/googleapis@ab2ad69

Source-Link: googleapis/googleapis-gen@6d1f0a7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmQxZjBhNzNhYTc5ZmU1N2RmZmRkOTUwODc2MjJkNDgyMDQ5OWZkNSJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
8d3c686 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
chore: remove redundant gRPC service config file
07dcf3f 
feat: specify retry configuration

PiperOrigin-RevId: 712493958

Source-Link: googleapis/googleapis@29aea41

Source-Link: googleapis/googleapis-gen@04bcbab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDRiY2JhYjQ1MDU5ODllOTg0YjE0MDNkNDM4ZmZmYzAzMTIxNDRhZiJ9
@gcf-owl-bot
fix: extend timeouts for check consistency
3df7170 
PiperOrigin-RevId: 717421943

Source-Link: googleapis/googleapis@07737e5

Source-Link: googleapis/googleapis-gen@c41ade9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQxYWRlOWVmN2E5MGExZTM4YmRhNzgxMzI0NDdhNGI3ZTUwYzExZCJ9
@gcf-owl-bot
feat: paging changes for bigquery
5c97186 
fix: add x-goog-request params to headers for LRO-polling methods
fix: remove extra protos in ESM & capture ESM in headers
docs: update comments for a Nodejs stream object

PiperOrigin-RevId: 721038181

Source-Link: googleapis/googleapis@331a41a

Source-Link: googleapis/googleapis-gen@e81b4c5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTgxYjRjNWI1MjA4ODk1ZjY2M2EyNDA0ODYxNWE1OWQ1NjM2ZjQxNSJ9
@gcf-owl-bot
chore: update copyright year for auto-generated protos
2313ade 
PiperOrigin-RevId: 732130682

Source-Link: googleapis/googleapis@9415ba0

Source-Link: googleapis/googleapis-gen@2905f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwNWY4MzM3NTZjMmIyMGIzMjgyYmU4NGI1MTFlMDQwZmU1NGYzMyJ9
@gcf-owl-bot
feat: publish row_key_schema fields in table proto and relevant admin…
0af0d7f 
… APIs to setup a table with a row_key_schema

PiperOrigin-RevId: 732197624

Source-Link: googleapis/googleapis@33b23a7

Source-Link: googleapis/googleapis-gen@cfb78ae
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2ZiNzhhZTliMDFjOWY2YmIwOTFkODQ2NzhiY2QwZGM5OTA3ZTczNCJ9
@gcf-owl-bot
feat: add MaterializedViews and LogicalViews APIs
b211452 
PiperOrigin-RevId: 733101782

Source-Link: googleapis/googleapis@05f571e

Source-Link: googleapis/googleapis-gen@6e6954c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmU2OTU0YzJkNDY4YWE4OWU1NmUzNDYzZWYxYWU0YzdkMDFmY2NlNiJ9
@gcf-owl-bot
docs: Fixed formatting of resource path strings
f7a5448 
PiperOrigin-RevId: 733415839

Source-Link: googleapis/googleapis@da20dfe

Source-Link: googleapis/googleapis-gen@86b7c0c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODZiN2MwY2JiYWVlYzgxMzRhNzZlODJkOWIyNGRjYjk3N2M5ZmI0YSJ9
@gcf-owl-bot
chore: Add grpc service config for ExecuteQuery API
b7ed46f 
PiperOrigin-RevId: 733462032

Source-Link: googleapis/googleapis@03183b7

Source-Link: googleapis/googleapis-gen@532cf74
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTMyY2Y3NGM2ZGNlMmFlZWUwYTUwNWU2Mzk1NWYzZTQ5OGYwZTFhYSJ9
@gcf-owl-bot
feat: Add PrepareQuery api and update ExecuteQuery to support it
2a6a971 
docs: Update ExecuteQuery API docs to reflect changes

PiperOrigin-RevId: 734273312

Source-Link: googleapis/googleapis@9513189

Source-Link: googleapis/googleapis-gen@a950280
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTk1MDI4MGQ1MDZiMmZkZDljNjZhMTA5OGMwMGY5MWQ4Zjc4MGI2NiJ9
@gcf-owl-bot
feat: add MaterializedViewName to ReadRows and SampleRowKeys
ca02e4d 
PiperOrigin-RevId: 735384675

Source-Link: googleapis/googleapis@47d236a

Source-Link: googleapis/googleapis-gen@7d15ec9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2QxNWVjOTFhNGQwYWRiOTBjODUxNjMyZTNmNzQ1NDFlNzhkYzUyMCJ9
@gcf-owl-bot
feat: add MaterializedViews and LogicalViews APIs
429c239 
PiperOrigin-RevId: 735407006

Source-Link: googleapis/googleapis@b80f49d

Source-Link: googleapis/googleapis-gen@9d5789e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWQ1Nzg5ZTQ1YWY4N2QzNzFmYmJhYjRkZjE0Njg5ODA3ZmMyYzMyMyJ9
@gcf-owl-bot
chore: update typescript gapic generator to 4.8.1
405d258 
feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671)
fix: add json files to tsconfig templates (#1692) (ba6be1d)

PiperOrigin-RevId: 735896588

Source-Link: googleapis/googleapis@3419af7

Source-Link: googleapis/googleapis-gen@f35ba11
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9
@gcf-owl-bot
feat: await/catch promises, and update listOperationsAsync return type
561e321 
PiperOrigin-RevId: 738212310

Source-Link: googleapis/googleapis@803b234

Source-Link: googleapis/googleapis-gen@4f44bd2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9
@danieljbruce
Merge branch 'main' into owl-bot-copy
9089905
@danieljbruce
Update headers
75ef448
@danieljbruce
Fix the rule compiler errors
cdef40d
@danieljbruce
Apply casting to solve some compile time errors
fbf9875
@danieljbruce
Downgrade the long library
6a8ef36 
# Conflicts:
#	package.json
@danieljbruce
ESM compatibility issues
e47d1fe 
Replace dot prop with methods. Fix the issues with long and downgrade escapeStringRegexp.
@danieljbruce
Solved the cluster info errors
a3f588a
@danieljbruce
Revert "ESM compatibility issues"
8ffc6c5 
This reverts commit e47d1fe.
@danieljbruce
Downgrade long
037ca07
@danieljbruce
Upgrade gax
120900b
@danieljbruce
Solve remaining linting issues
545a2e1
danieljbruce and others added 7 commits April 10, 2025 14:30
@danieljbruce
update p-queue types
00c49b3
@danieljbruce
eliminate PQueue
05fcb34
@danieljbruce
Merge branch 'main' of https://github.com/googleapis/nodejs-bigtable …
fbcaabc 
…into owl-bot-copy-once-again-try-the-changes-add-script-run-script

# Conflicts:
#	src/client-side-metrics/exporter.ts
#	src/client-side-metrics/gcp-metrics-handler.ts
#	system-test/gcp-metrics-handler.ts
@danieljbruce
linting fix
5d185e3
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
ae9b6d8 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
Merge branch 'owl-bot-copy-once-again-try-the-changes-add-script-run-…
9bc4ea0 
…script' of https://github.com/googleapis/nodejs-bigtable into owl-bot-copy-once-again-try-the-changes-add-script-run-script
@danieljbruce
use lower uuid version
d03e384 
Now we don’t get the ??= unexpected token error.
@danieljbruce danieljbruce added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@danieljbruce danieljbruce added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@danieljbruce danieljbruce requested a review from sofisl April 16, 2025 13:30
@leahecole leahecole added the snippet-bot:force-run Force snippet-bot runs its logic label Apr 16, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Apr 16, 2025
sofisl
sofisl reviewed Apr 16, 2025
View reviewed changes
.github/.OwlBot.lock.yaml Outdated
digest: sha256:e92044720ab3cb6984a70b0c6001081204375959ba3599ef6c42dd99a7783a67
# created: 2023-11-10T00:24:05.581078808Z
image: 'gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest'
digest: 'sha256:c7e4968cfc97a204a4b2381f3ecb55cabc40c4cccf88b1ef8bef0d976be87fee'
Copy link
Contributor

@sofisl sofisl Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it matters but it doesn't seem like these had quotes beforehand.

Copy link
Contributor Author

@danieljbruce danieljbruce Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I changed it back.

src/mutation.ts Outdated
import arrify = require('arrify');
import * as is from 'is';
import * as Long from 'long';
import Long = require('long');
Copy link
Contributor

@sofisl sofisl Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this is probably why long needs to be a dependency. Do you know why the way its being imported is changing to require?

Copy link
Contributor Author

@danieljbruce danieljbruce Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, some compiler or linting error wasn't letting us do it the old way, but we must have made a recent change because it doesn't seem to be a problem anymore so I changed it back to an import.

test/chunktransformer.ts Outdated
import * as assert from 'assert';
import {describe, it, before, beforeEach, afterEach} from 'mocha';
import * as Long from 'long';
import Long = require('long');
Copy link
Contributor

@sofisl sofisl Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this import statement changing?

Copy link
Contributor Author

@danieljbruce danieljbruce Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, some compiler or linting error wasn't letting us do it the old way, but we must have made a recent change because it doesn't seem to be a problem anymore so I changed it back to an import.

@danieljbruce danieljbruce requested a review from sofisl April 16, 2025 20:34
@danieljbruce danieljbruce added the automerge Merge the pull request once unit tests and other checks pass. label Apr 16, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit e50b67d into main Apr 16, 2025
18 of 21 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 16, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy-once-again-try-the-changes-add-script-run-script branch April 16, 2025 21:10
@release-please release-please bot mentioned this pull request Apr 16, 2025
Merged
@danieljbruce danieljbruce mentioned this pull request Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sofisl sofisl sofisl approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/nodejs-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danieljbruce @sofisl @leahecole @yoshi-kokoro @feywind