feat: Move the metrics handler fixture#1570
Merged
gcf-merge-on-green[bot] merged 1 commit intomainfrom Feb 24, 2025
Merged
Conversation
kevkim-codes
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR simply moves the metrics handler fixture used for tests from the
testfolder to thetest-commonfolder. In the next PR the metrics handler fixture will be used for both tests and system tests and when system tests import a file from the test folder and we runnpm run system-testit runs both the test and the system test suite and we don't want that so right now we are moving the fixture to thetest-commonfolder.Next steps:
The diagram below shows how the fixture is going to be used in the next PR in system tests.