fix: Conformance test sample rowkeys generic deadline#1562
Merged
kevkim-codes merged 33 commits intogoogleapis:mainfrom Jan 7, 2025
Merged
fix: Conformance test sample rowkeys generic deadline#1562kevkim-codes merged 33 commits intogoogleapis:mainfrom
kevkim-codes merged 33 commits intogoogleapis:mainfrom
Conversation
test: Make the ReadRows service in tests more modular (googleapis#1462)
…nodejs-bigtable into samplerowkey-genericheader
…amplerowkeys-genericdeadline
cindy-peng
approved these changes
Dec 23, 2024
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
danieljbruce
approved these changes
Jan 7, 2025
Contributor
danieljbruce
left a comment
There was a problem hiding this comment.
Looks good for meeting the needs of the tests. We may want to add retry behaviour to sampleRowKeys at some point.
| }; | ||
|
|
||
| const table = getTableInfo(client, tableName); | ||
| const sampleRowKeysResponse = table.sampleRowKeys(); |
Contributor
There was a problem hiding this comment.
I think this may actually need await before table.sampleRowKeys().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes generic deadline issue for sample rowkeys method. We were not handling for deadline exceeded errors in the original method as we were expecting GAX to handle it. Hopefully, down the road we will have GAX handle these at a parent level and send back the proper error code.