Fix: TestMutateRow_Generic_Headers#1540
Merged
gcf-merge-on-green[bot] merged 16 commits intogoogleapis:mainfrom Dec 16, 2024
Merged
Fix: TestMutateRow_Generic_Headers#1540gcf-merge-on-green[bot] merged 16 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 16 commits intogoogleapis:mainfrom
Conversation
test: Make the ReadRows service in tests more modular (googleapis#1462)
danieljbruce
approved these changes
Dec 12, 2024
Contributor
danieljbruce
left a comment
There was a problem hiding this comment.
Eventually we'll have to get mutateRow service to use the handwritten layer.
| normalizeCallback(async rawRequest => { | ||
| const {request} = rawRequest; | ||
| const {request: mutateRequest} = request; | ||
| const {appProfileId, mutations, tableName, rowKey} = mutateRequest; |
Contributor
There was a problem hiding this comment.
Eventually we will want the appProfileId to be able to be set per mutateRow call, but the change to use appProfileId to address the test is good for now.
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutate rows is grabbing the
appProfileIdfrom the client.nodejs-bigtable/src/tabular-api-surface.ts
Line 765 in eb2cd9f
We should modify the test proxy test here to do the same.