fix: Fix TestReadRows_Generic_CloseClient conformance test by passing grpc status codes for closed client errors#1524
Merged
gcf-merge-on-green[bot] merged 10 commits intogoogleapis:mainfrom Dec 2, 2024
Conversation
… grpc status codes for closed client errors
kevkim-codes
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TestReadRows_Generic_CloseClient conformance test is failing. The assert that was failing was failing because the client was sending back an error saying the client had been closed without providing a status code for the error, but the assertion requires a non-zero status code to be present. With the new code change, the error saying that the client has been closed will now have a
CANCELLEDstatus code as was recommended by Gemini and the assertion check will pass and the test will pass too.