fix: Remove bigtable instances left over when system tests run #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instances are not currently being cleaned up by the reap instances function because a filter is not selecting instances based on the right prefix. It looks like this fix should solve the issue.
Instances are not currently being cleaned up by the reap instances function because a filter is not selecting instances based on the right prefix. It looks like this fix should solve the issue.
…jbruce/nodejs-bigtable into remove-bigtable-instances
bcoe
approved these changes
Apr 28, 2023
This was referenced May 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should remove Bigtable instances before the system tests run so that the number of instances that have been created never exceed quotas and should fix the flakey tests due to Insufficient node quotas.