fix: Integration test close function again#1103
Merged
danieljbruce merged 12 commits intogoogleapis:mainfrom Jul 12, 2022
Merged
fix: Integration test close function again#1103danieljbruce merged 12 commits intogoogleapis:mainfrom
danieljbruce merged 12 commits intogoogleapis:mainfrom
Conversation
…into integration-test-close-function-again # Conflicts: # src/table.ts
danieljbruce
commented
Jun 20, 2022
Contributor
Author
danieljbruce
left a comment
There was a problem hiding this comment.
A comment to clarify the original problem.
| */ | ||
| promisifyAll(Bigtable, { | ||
| exclude: ['instance', 'operation', 'request'], | ||
| exclude: ['close', 'instance', 'operation', 'request'], |
Contributor
Author
There was a problem hiding this comment.
In the absence of this change, the test just seems to hang forever.
There was a problem hiding this comment.
promisifyAll turns a cb based function into a promise based function, it looks like close was already a promise, and did not expect a callback as an argument:
close(): Promise<void[]>
Contributor
Author
There was a problem hiding this comment.
Yes. I am making sure the reader of this PR knows why this change is necessary.
Contributor
Author
There was a problem hiding this comment.
Thanks for clarifying why the test hangs in this PR though!
bcoe
approved these changes
Jun 20, 2022
| */ | ||
| promisifyAll(Bigtable, { | ||
| exclude: ['instance', 'operation', 'request'], | ||
| exclude: ['close', 'instance', 'operation', 'request'], |
There was a problem hiding this comment.
promisifyAll turns a cb based function into a promise based function, it looks like close was already a promise, and did not expect a callback as an argument:
close(): Promise<void[]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the close function where promises of promises were once returned, but now we simply return a promise so that when we use
awaitthen the code is executed properly.