This repository was archived by the owner on Feb 7, 2026. It is now read-only.
fix: call rowQueue insert callback only if present#1128
Merged
Conversation
steffnay
approved these changes
Jun 17, 2022
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
🤖 I have created a release *beep* *boop* --- ## [6.0.1](v6.0.0...v6.0.1) (2022-06-17) ### Bug Fixes * call rowQueue insert callback only if present ([#1128](#1128)) ([17a0c0d](17a0c0d)) * **deps:** update dependency @google-cloud/paginator to v4 ([#1116](#1116)) ([073abc0](073abc0)) * **deps:** update dependency @google-cloud/storage to v6 ([#1119](#1119)) ([d607e5a](d607e5a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Feb 3, 2026
🤖 I have created a release *beep* *boop* --- ## [6.0.1](googleapis/nodejs-bigquery@v6.0.0...v6.0.1) (2022-06-17) ### Bug Fixes * call rowQueue insert callback only if present ([#1128](googleapis/nodejs-bigquery#1128)) ([17a0c0d](googleapis/nodejs-bigquery@17a0c0d)) * **deps:** update dependency @google-cloud/paginator to v4 ([#1116](googleapis/nodejs-bigquery#1116)) ([073abc0](googleapis/nodejs-bigquery@073abc0)) * **deps:** update dependency @google-cloud/storage to v6 ([#1119](googleapis/nodejs-bigquery#1119)) ([d607e5a](googleapis/nodejs-bigquery@d607e5a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue where callback is called even if it's not present.
Issue happens when using
table.createInsertStream()and after success/failure callback is being called, but it's not passed inroqQueue.addmethod.