feat(spanner-admin): spanner admin source + create instance tool by gRedHeadphone · Pull Request #2209 · googleapis/mcp-toolbox

gRedHeadphone · 2025-12-19T10:01:53Z

Description

Added Spanner admin source to manage spanner instance and database, and added spanner create instance tool.

PR Checklist

Make sure you reviewed
CONTRIBUTING.md
Make sure to open an issue as a
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Make sure to add ! if this involve a breaking change

🛠️ Fixes #2208

gemini-code-assist · 2025-12-19T10:02:11Z

Summary of Changes

Hello @gRedHeadphone, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the toolbox by integrating Google Cloud Spanner administration capabilities. It provides a new source for interacting with the Spanner Admin API and a specific tool to create Spanner instances, allowing for automated infrastructure management. The changes include core logic implementation, configuration updates, and thorough documentation to support the new features.

Highlights

New Spanner Admin Source: Introduced a new Spanner Admin source to manage Google Cloud Spanner instances and databases, enabling AI-powered tools to interact with the Spanner Admin API.
Spanner Create Instance Tool: Added a new tool, spanner-create-instance, which allows for the programmatic creation of Cloud Spanner instances with configurable parameters like project, instance ID, display name, configuration, node count, processing units, and edition.
Comprehensive Documentation: New documentation files (SPANNERADMIN_README.md, spanner-admin.md, spanner-create-instance.md) have been added to detail the features, prerequisites, installation, usage, and configuration of the Spanner Admin source and tool.
Integration Tests: A new integration test step for spanneradmin has been added to the CI pipeline, along with a dedicated integration test file (spanneradmin_integration_test.go) to ensure the new functionality works as expected.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new spanner-admin source and a spanner-create-instance tool, complete with comprehensive documentation, unit tests, and a robust integration test. The overall implementation is of high quality and aligns well with the existing codebase patterns. My feedback includes a couple of suggestions to enhance parameter descriptions for better AI model interaction and to correct a minor formatting issue in the documentation.

github-actions · 2025-12-19T10:05:11Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

…e instance

github-actions · 2025-12-19T10:14:13Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

Yuan325

Hi, please see the following updates from #2204 . Let me know if there's any questions :) Thank you!

Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

github-actions · 2025-12-22T05:29:43Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

github-actions · 2025-12-22T05:53:06Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

github-actions · 2025-12-29T08:17:27Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

github-actions · 2025-12-31T07:49:57Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

averikitsch

@averikitsch to review and confirm any default settings.

github-actions · 2026-01-09T05:10:25Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

github-actions · 2026-01-09T05:24:56Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

github-actions · 2026-01-23T07:08:55Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

github-actions · 2026-01-28T07:13:17Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

github-actions · 2026-01-28T09:39:41Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

gRedHeadphone · 2026-01-28T10:53:22Z

@averikitsch @Yuan325 Please review

github-actions · 2026-02-04T18:07:49Z

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-2209/

feat(spanner-admin): spanner admin source + create instance tool

302b564

gRedHeadphone requested a review from a team December 19, 2025 10:01

blunderbuss-gcf Bot assigned duwenxin99 Dec 19, 2025

gemini-code-assist Bot reviewed Dec 19, 2025

View reviewed changes

Comment thread docs/en/resources/tools/spanneradmin/spanner-create-instance.md Outdated

Comment thread internal/tools/spanneradmin/spannercreateinstance/spannercreateinstance.go Outdated

chore: update parameter description & format docs table spanner creat…

5b7f5a3

…e instance

Yuan325 reviewed Dec 20, 2025

View reviewed changes

Comment thread internal/tools/spanneradmin/spannercreateinstance/spannercreateinstance.go Outdated

gRedHeadphone and others added 13 commits December 22, 2025 10:52

Update internal/sources/spanneradmin/spanneradmin.go

e6de217

Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

4f62db4

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

e831f71

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

330dd84

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

7d79f49

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

09c979d

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

a9edd5e

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

4170fe3

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

f9f34b1

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

62095fe

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

511c465

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Update internal/tools/spanneradmin/spannercreateinstance/spannercreat…

c67b0cf

…einstance.go Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Merge branch 'main' into spanner-create-instance

1475b4d

chore: minor fixes

af62ddf

Merge branch 'main' into spanner-create-instance

3a317a3

gRedHeadphone requested a review from Yuan325 December 31, 2025 07:46

Merge branch 'main' into spanner-create-instance

6d43488

duwenxin99 assigned Yuan325 and unassigned duwenxin99 Jan 6, 2026

averikitsch reviewed Jan 8, 2026

View reviewed changes

averikitsch self-assigned this Jan 8, 2026

Merge branch 'main' into spanner-create-instance

589059e

chore: header update + main merge fixes

de7c65e

gRedHeadphone requested a review from averikitsch January 9, 2026 05:32

Yuan325 removed their assignment Jan 21, 2026

Yuan325 added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jan 21, 2026

Merge branch 'main' into spanner-create-instance

a7d0f19

Merge branch 'main' into spanner-create-instance

668ca5d

chore: fix for configuration file changes

caa33d4

Merge branch 'main' into spanner-create-instance

2f4224f

Conversation

gRedHeadphone commented Dec 19, 2025

Description

PR Checklist

Uh oh!

gemini-code-assist Bot commented Dec 19, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

github-actions Bot commented Dec 19, 2025

Uh oh!

Yuan325 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 22, 2025

Uh oh!

github-actions Bot commented Dec 22, 2025

Uh oh!

github-actions Bot commented Dec 29, 2025

Uh oh!

github-actions Bot commented Dec 31, 2025

Uh oh!

averikitsch left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 9, 2026

Uh oh!

github-actions Bot commented Jan 9, 2026

Uh oh!

github-actions Bot commented Jan 23, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

gRedHeadphone commented Jan 28, 2026

Uh oh!

github-actions Bot commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants