Skip to content

fix(source/cloud-sql-mssql): remove ip address field#1822

Merged
Yuan325 merged 3 commits into
mainfrom
mssql-ip
Oct 31, 2025
Merged

fix(source/cloud-sql-mssql): remove ip address field#1822
Yuan325 merged 3 commits into
mainfrom
mssql-ip

Conversation

@Yuan325

@Yuan325 Yuan325 commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Description

Removing the ipAddress field since it is not an input for Cloud SQL SQL Server source.

Kept the variable in Source's config but removed this variable from everywhere else in the code. This will PREVENT a breaking change since the validator won't flag it as an "extra field".

Will have to update the following as well:
(1) Cloud docs https://cloud.google.com/sql/docs/sqlserver/pre-built-tools-with-mcp-toolbox
(2) gemini-cli-extensions https://github.com/gemini-cli-extensions/cloud-sql-sqlserver

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #1549

@Yuan325 Yuan325 requested a review from a team October 30, 2025 03:53
@Yuan325 Yuan325 changed the title fix(source/cloud-sql-mssql): remove ip address field fix(source/cloud-sql-mssql)!: remove ip address field Oct 30, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Comment thread internal/sources/cloudsqlmssql/cloud_sql_mssql.go
Comment thread internal/sources/cloudsqlmssql/cloud_sql_mssql.go
@Yuan325 Yuan325 changed the title fix(source/cloud-sql-mssql)!: remove ip address field fix(source/cloud-sql-mssql): remove ip address field Oct 30, 2025
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

🧨 Preview deployments removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove IP address from Cloud SQL SQL Server source

2 participants