Skip to content

feat: Added basic prompt structs#1643

Merged
twishabansal merged 45 commits into
feat-promptfrom
prompt-basic
Oct 28, 2025
Merged

feat: Added basic prompt structs#1643
twishabansal merged 45 commits into
feat-promptfrom
prompt-basic

Conversation

@twishabansal

@twishabansal twishabansal commented Oct 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Added core data structures and logic for prompts and arguments.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ One of multiple PRs to support #1040

@twishabansal twishabansal changed the title Prompt basic feat: Added basic prompt structs Oct 7, 2025
@twishabansal twishabansal marked this pull request as ready for review October 7, 2025 15:25
@twishabansal twishabansal requested a review from a team October 7, 2025 15:25
Yuan325
Yuan325 requested changes Oct 9, 2025
View reviewed changes
Comment thread internal/prompts/arguments_test.go Outdated
Comment thread internal/prompts/arguments_test.go Outdated
Comment thread internal/prompts/arguments_test.go Outdated
Comment thread internal/prompts/arguments_test.go Outdated
Comment thread internal/prompts/arguments_test.go Outdated
Comment thread internal/prompts/arguments.go Outdated
Comment thread internal/prompts/prompts.go Outdated
Comment thread internal/prompts/prompts.go Outdated
Comment thread internal/prompts/prompts.go Outdated
Comment thread internal/prompts/prompts_test.go Outdated
@twishabansal twishabansal requested a review from Yuan325 October 13, 2025 10:07
Yuan325
Yuan325 requested changes Oct 21, 2025
View reviewed changes

@Yuan325 Yuan325 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM! Should be good to go after this :)

Comment thread internal/prompts/arguments.go Outdated
Comment thread internal/prompts/arguments.go Outdated
Comment thread internal/prompts/arguments.go
Comment thread internal/prompts/arguments_test.go Outdated
Comment thread internal/prompts/arguments_test.go Outdated
Comment thread internal/prompts/messages.go Outdated
Comment thread internal/prompts/messages.go Outdated
Comment thread internal/prompts/messages.go Outdated
Comment thread internal/prompts/messages_test.go Outdated
Comment thread internal/prompts/prompts.go Outdated
twishabansal and others added 15 commits October 21, 2025 11:00
@twishabansal
Merge branch 'main' into prompt-basic
0e3824b
@twishabansal @Yuan325
Apply suggestion from @Yuan325
f4f259e 
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
@twishabansal @Yuan325
Apply suggestion from @Yuan325
6cdd504 
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
@twishabansal @Yuan325
Update internal/prompts/messages_test.go
b62218e 
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
@twishabansal
Merge branch 'main' into prompt-basic
3d9f199
@twishabansal
remove metadata
e1cb60d
@twishabansal
fix types
a461fb6
@twishabansal
Merge branch 'main' into prompt-basic
44c49ab
@twishabansal
Merge branch 'main' into prompt-basic
93a8149
@twishabansal @Yuan325
Update internal/prompts/arguments_test.go
85e8065 
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
@twishabansal @Yuan325
Update internal/prompts/arguments_test.go
50e21de 
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
@twishabansal
add comment
ceb4e14
@twishabansal
make userrole and assistant role consts
cbfb088
@twishabansal
improve code readability
ca21de9
@twishabansal
fix names
cd36d6f
@Yuan325 Yuan325 self-requested a review October 27, 2025 20:05
@Yuan325 Yuan325 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2025
@twishabansal twishabansal changed the base branch from main to feat-prompt October 28, 2025 05:17
@twishabansal twishabansal removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2025
@twishabansal twishabansal merged commit 86469df into feat-prompt Oct 28, 2025
14 checks passed
@twishabansal twishabansal deleted the prompt-basic branch October 28, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yuan325 Yuan325 Yuan325 approved these changes

Assignees

@Yuan325 Yuan325

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twishabansal @Yuan325