feat(bigquery): add maximumBytesBilled source config by Deeven-Seru · Pull Request #2724 · googleapis/mcp-toolbox

Deeven-Seru · 2026-03-12T13:22:25Z

Fixes #2719
Summary

add optional maximumBytesBilled to BigQuery source config
apply per-query cap to dry runs and query execution
document and test config parsing/initialization

Testing

go test ./internal/sources/bigquery ./internal/tools/bigquery/...

gemini-code-assist · 2026-03-12T13:22:50Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the BigQuery source configuration by adding a new "maximumBytesBilled" option. This feature empowers users to define a maximum amount of data (in bytes) that a BigQuery query can process, thereby providing a crucial mechanism for cost control. Queries that are projected to exceed this limit will now fail early, preventing unexpected billing. The change is integrated across query dry runs and execution, and is thoroughly documented and tested to ensure reliability and ease of use.

Highlights

New Configuration Option: Introduced an optional "maximumBytesBilled" field to the BigQuery source configuration, allowing users to set a per-query byte scanned cap.
Query Execution Control: Implemented logic to apply the "maximumBytesBilled" cap to both dry runs and actual query executions, ensuring queries exceeding the limit fail before consuming resources.
Documentation and Testing: Updated documentation to reflect the new configuration and added comprehensive test cases for parsing and initialization of "maximumBytesBilled".

Changelog

docs/en/resources/sources/bigquery.md
- Added "maximumBytesBilled" to BigQuery source configuration examples.
- Included "maximumBytesBilled" in the BigQuery source reference table with its description.
internal/sources/bigquery/bigquery.go
- Added "MaximumBytesBilled" field to the Config struct.
- Initialized "MaximumBytesBilled" in the Initialize method.
- Added "MaximumBytesBilled" field to the Source struct.
- Implemented GetMaximumBytesBilled method for the Source struct.
- Applied MaxBytesBilled to the BigQuery query object if "MaximumBytesBilled" is configured.
internal/sources/bigquery/bigquery_test.go
- Added a test case to verify parsing of "maximumBytesBilled" from YAML configuration.
- Introduced a new test suite, TestInitialize_MaximumBytesBilled, to validate the initialization of the "MaximumBytesBilled" field.
internal/tools/bigquery/bigqueryanalyzecontribution/bigqueryanalyzecontribution.go
- Added GetMaximumBytesBilled() to the compatibleSource interface.
- Passed the maximumBytesBilled value from the source to the bqutil.DryRunQuery function.
internal/tools/bigquery/bigquerycommon/util.go
- Updated the DryRunQuery function signature to accept a maximumBytesBilled parameter.
- Set the MaximumBytesBilled property in the BigQuery Query request during dry runs.
internal/tools/bigquery/bigqueryexecutesql/bigqueryexecutesql.go
- Added GetMaximumBytesBilled() to the compatibleSource interface.
- Passed the maximumBytesBilled value from the source to the bqutil.DryRunQuery function.
internal/tools/bigquery/bigqueryforecast/bigqueryforecast.go
- Added GetMaximumBytesBilled() to the compatibleSource interface.
- Passed the maximumBytesBilled value from the source to the bqutil.DryRunQuery function.
internal/tools/bigquery/bigquerysql/bigquerysql.go
- Added GetMaximumBytesBilled() to the compatibleSource interface.
- Passed the maximumBytesBilled value from the source to the bqutil.DryRunQuery function.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a maximumBytesBilled configuration for the BigQuery source, which is a valuable addition for managing query costs. The implementation is thorough, with changes applied to the source configuration, query execution logic, tool integrations, documentation, and tests. My review includes one suggestion to enhance the robustness of the new configuration field by adding validation.

Deeven-Seru · 2026-03-12T13:38:10Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new maximumBytesBilled configuration option for the BigQuery source to allow for cost control on queries. The implementation adds the new setting and propagates it to query executions and dry runs in the relevant tools. The changes include validation for the new setting, updated documentation, and new tests for parsing and initialization. The implementation appears correct and complete. I have reviewed the changes and found no issues.

yathu-arulnanthy-gtg

Nice one 🔥

Deeven-Seru · 2026-03-24T04:01:21Z

Nice one 🔥

@yathu-arulnanthy-gtg thanks 😁

duwenxin99 · 2026-03-24T14:55:45Z

Hi @Genesis929, could you review this BQ change? Thanks!

…max-bytes

nemetron · 2026-03-30T12:46:52Z

amazing..🫡

duwenxin99 · 2026-04-15T19:19:13Z

/gcbrun

Fixes #2719 Summary - add optional `maximumBytesBilled` to BigQuery source config\n- apply per-query cap to dry runs and query execution- document and test config parsing/initialization ## Testing - go test ./internal/sources/bigquery ./internal/tools/bigquery/... --------- Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 42f2d07

…pis#2724) Fixes googleapis#2719 Summary - add optional `maximumBytesBilled` to BigQuery source config\n- apply per-query cap to dry runs and query execution- document and test config parsing/initialization ## Testing - go test ./internal/sources/bigquery ./internal/tools/bigquery/... --------- Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 42f2d07

Deeven-Seru · 2026-04-16T03:27:57Z

🎉

…pis#2724) Fixes googleapis#2719 Summary - add optional `maximumBytesBilled` to BigQuery source config\n- apply per-query cap to dry runs and query execution- document and test config parsing/initialization ## Testing - go test ./internal/sources/bigquery ./internal/tools/bigquery/... --------- Co-authored-by: Wenxin Du <117315983+duwenxin99@users.noreply.github.com> 42f2d07

🤖 I have created a release *beep* *boop* --- ## [1.2.0](v1.1.0...v1.2.0) (2026-05-07) ### Features * Add support for HTTPS/TLS listener ([#3126](#3126)) ([8bc385d](8bc385d)) * **source/bigquery:** Add maximumBytesBilled source config ([#2724](#2724)) ([42f2d07](42f2d07)) * **source/cloud-storage:** Add bucket and object management tools ([#3129](#3129)) ([8de9bcf](8de9bcf)) * **source/cloud-storage:** Add Cloud Storage source with list_objects and read_object tools ([#3081](#3081)) ([da27b37](da27b37)) * **source/cloud-storage:** Add write/copy/move/delete object tools ([#3139](#3139)) ([b225fc4](b225fc4)) * **tools/knowledge-catalog:** Search Data Quality Scans ([#2444](#2444)) ([1c63551](1c63551)) ### Bug Fixes * Allow converting string literal block with list ([#3050](#3050)) ([36ab2a9](36ab2a9)), closes [#3023](#3023) * **mcp:** Implement router-level logger injection for MCP auth ([#3067](#3067)) ([ccc7cf5](ccc7cf5)) * Prevent test.db from being created during unit tests ([#3042](#3042)) ([d10d2ca](d10d2ca)) * Remove hardcoded * allowed origin for sse ([#3054](#3054)) ([c4c7bd9](c4c7bd9)) * **sources/postgres:** Apply URL encoding to query string params ([#3020](#3020)) ([6b860f4](6b860f4)) * **tool/looker-conversational-analytics:** OAuth token in GDA payload fix ([#3058](#3058)) ([6632d96](6632d96)) * **tools/bigquery-execute-sql:** Avoid surfacing invalid queries as MCP 500s ([#3056](#3056)) ([7ed92c8](7ed92c8)) * **tools/looker:** Fix OAuth for Converational Analytics ([#3044](#3044)) ([f9e3e55](f9e3e55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [1.2.0](googleapis/mcp-toolbox@v1.1.0...v1.2.0) (2026-05-07) ### Features * Add support for HTTPS/TLS listener ([googleapis#3126](googleapis#3126)) ([8bc385d](googleapis@8bc385d)) * **source/bigquery:** Add maximumBytesBilled source config ([googleapis#2724](googleapis#2724)) ([42f2d07](googleapis@42f2d07)) * **source/cloud-storage:** Add bucket and object management tools ([googleapis#3129](googleapis#3129)) ([8de9bcf](googleapis@8de9bcf)) * **source/cloud-storage:** Add Cloud Storage source with list_objects and read_object tools ([googleapis#3081](googleapis#3081)) ([da27b37](googleapis@da27b37)) * **source/cloud-storage:** Add write/copy/move/delete object tools ([googleapis#3139](googleapis#3139)) ([b225fc4](googleapis@b225fc4)) * **tools/knowledge-catalog:** Search Data Quality Scans ([googleapis#2444](googleapis#2444)) ([1c63551](googleapis@1c63551)) ### Bug Fixes * Allow converting string literal block with list ([googleapis#3050](googleapis#3050)) ([36ab2a9](googleapis@36ab2a9)), closes [googleapis#3023](googleapis#3023) * **mcp:** Implement router-level logger injection for MCP auth ([googleapis#3067](googleapis#3067)) ([ccc7cf5](googleapis@ccc7cf5)) * Prevent test.db from being created during unit tests ([googleapis#3042](googleapis#3042)) ([d10d2ca](googleapis@d10d2ca)) * Remove hardcoded * allowed origin for sse ([googleapis#3054](googleapis#3054)) ([c4c7bd9](googleapis@c4c7bd9)) * **sources/postgres:** Apply URL encoding to query string params ([googleapis#3020](googleapis#3020)) ([6b860f4](googleapis@6b860f4)) * **tool/looker-conversational-analytics:** OAuth token in GDA payload fix ([googleapis#3058](googleapis#3058)) ([6632d96](googleapis@6632d96)) * **tools/bigquery-execute-sql:** Avoid surfacing invalid queries as MCP 500s ([googleapis#3056](googleapis#3056)) ([7ed92c8](googleapis@7ed92c8)) * **tools/looker:** Fix OAuth for Converational Analytics ([googleapis#3044](googleapis#3044)) ([f9e3e55](googleapis@f9e3e55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

Deeven-Seru requested review from a team as code owners March 12, 2026 13:22

blunderbuss-gcf Bot assigned duwenxin99 Mar 12, 2026

gemini-code-assist Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread internal/sources/bigquery/bigquery.go Outdated

Deeven-Seru force-pushed the feat-2719-bigquery-max-bytes branch from 5558999 to acc5afb Compare March 12, 2026 13:28

feat(bigquery): add maximumBytesBilled source config

04d8357

Deeven-Seru force-pushed the feat-2719-bigquery-max-bytes branch from b05f5b3 to 04d8357 Compare March 12, 2026 13:37

gemini-code-assist Bot reviewed Mar 12, 2026

View reviewed changes

Deeven-Seru mentioned this pull request Mar 12, 2026

feat(bigquery): add maximumBytesBilled to source config for query cost protection #2719

Closed

yathu-arulnanthy-gtg approved these changes Mar 24, 2026

View reviewed changes

duwenxin99 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 24, 2026

duwenxin99 approved these changes Mar 24, 2026

View reviewed changes

shobsi approved these changes Mar 25, 2026

View reviewed changes

shobsi requested a review from Genesis929 March 25, 2026 19:22

Merge remote-tracking branch 'upstream/main' into feat-2719-bigquery-…

9ce9f51

…max-bytes

Deeven-Seru and others added 4 commits March 31, 2026 20:27

Merge branch 'main' into feat-2719-bigquery-max-bytes

b4b4d3f

Merge branch 'main' into feat-2719-bigquery-max-bytes

bc33f42

Merge branch 'main' into feat-2719-bigquery-max-bytes

fc7d917

test(bigquery): fix typo in YAML kind and expected error string

f8aa955

Deeven-Seru force-pushed the feat-2719-bigquery-max-bytes branch from 068f21f to f8aa955 Compare April 14, 2026 07:30

Merge branch 'main' into feat-2719-bigquery-max-bytes

e4c8e0a

duwenxin99 enabled auto-merge (squash) April 15, 2026 19:19

duwenxin99 merged commit 42f2d07 into googleapis:main Apr 15, 2026
22 checks passed

release-please Bot mentioned this pull request Apr 15, 2026

chore(main): release 1.2.0 #3059

Merged

BrewTestBot mentioned this pull request May 7, 2026

mcp-toolbox 1.2.0 Homebrew/homebrew-core#281497

Merged

This was referenced Jun 10, 2026

feat(bigquery): wire maximumBytesBilled into prebuilt config via env var #3384

Open

fix(bigquery): wire maximumBytesBilled into prebuilt config #3385

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bigquery): add maximumBytesBilled source config#2724

feat(bigquery): add maximumBytesBilled source config#2724
duwenxin99 merged 7 commits into
googleapis:mainfrom
Deeven-Seru:feat-2719-bigquery-max-bytes

Deeven-Seru commented Mar 12, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Deeven-Seru commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

yathu-arulnanthy-gtg left a comment

Uh oh!

Deeven-Seru commented Mar 24, 2026

Uh oh!

duwenxin99 commented Mar 24, 2026

Uh oh!

nemetron commented Mar 30, 2026

Uh oh!

duwenxin99 commented Apr 15, 2026

Uh oh!

Uh oh!

Deeven-Seru commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Deeven-Seru commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

gemini-code-assist Bot commented Mar 12, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Deeven-Seru commented Mar 12, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

yathu-arulnanthy-gtg left a comment

Choose a reason for hiding this comment

Uh oh!

Deeven-Seru commented Mar 24, 2026

Uh oh!

duwenxin99 commented Mar 24, 2026

Uh oh!

nemetron commented Mar 30, 2026

Uh oh!

duwenxin99 commented Apr 15, 2026

Uh oh!

Uh oh!

Deeven-Seru commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Deeven-Seru commented Mar 12, 2026 •

edited

Loading