-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Bug: nil panic in SSE session lookup for /mcp requests #2680
Copy link
Copy link
Closed
Labels
priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.status: help wantedStatus: Unplanned work open to contributions from the community.Status: Unplanned work open to contributions from the community.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.status: help wantedStatus: Unplanned work open to contributions from the community.Status: Unplanned work open to contributions from the community.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Bug Summary
POST /mcp?sessionId=...can panic withruntime error: invalid memory address or nil pointer dereferenceininternal/server/mcp.go.Impact
This crashes request handling for SSE-backed MCP flows in staging and returns HTTP 500 to clients after successful
/mcp/ssesession bootstrap.Reproduction
GET /mcp/sseand capturesessionIdfromevent: endpoint.POST /mcp?sessionId=<id>.(*sseManager).getaroundmcp.go:64.Proposed Fix
sseManager.getnil-safe (treat nil map entries as unavailable).sessionIdis provided but session is unavailable, instead of continuing.