refactor(internal/config): remove veneer field from Library#4793
Merged
julieqiu merged 1 commit intogoogleapis:mainfrom Mar 24, 2026
Merged
refactor(internal/config): remove veneer field from Library#4793julieqiu merged 1 commit intogoogleapis:mainfrom
julieqiu merged 1 commit intogoogleapis:mainfrom
Conversation
Remove unused veneer field from librarian.yaml. Fixes googleapis#4276
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4793 +/- ##
==========================================
- Coverage 81.25% 81.24% -0.01%
==========================================
Files 129 129
Lines 10891 10888 -3
==========================================
- Hits 8849 8846 -3
Misses 1399 1399
Partials 643 643 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively removes the unused veneer field from the Library configuration. The changes are applied consistently across the codebase, including configuration structs, documentation, test data, and related logic. The refactoring is clean and correct. I have one minor suggestion to simplify the isVeneer function to make it more idiomatic.
jameslynnwu
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused veneer field from librarian.yaml.
Fixes #4276