Skip to content

cleanup(sidekick/config): remove support for conformance-root#4491

Merged
jameslynnwu merged 2 commits intomainfrom
remove-root
Mar 10, 2026
Merged

cleanup(sidekick/config): remove support for conformance-root#4491
jameslynnwu merged 2 commits intomainfrom
remove-root

Conversation

@jameslynnwu
Copy link
Copy Markdown
Contributor

googleapis/google-cloud-rust#4921 removes the last root_name that has the -root suffix, so no longer need to support.

googleapis/google-cloud-rust#4921 removes the
last root_name that has the -root suffix, so no longer need to support.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes support for the deprecated conformance-root source root. The change itself is correct.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.73%. Comparing base (4ef42e7) to head (b742307).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4491   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files         106      106           
  Lines        8736     8736           
=======================================
  Hits         7053     7053           
  Misses       1189     1189           
  Partials      494      494           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jameslynnwu jameslynnwu marked this pull request as ready for review March 10, 2026 19:37
@jameslynnwu jameslynnwu requested review from a team as code owners March 10, 2026 19:37
@jameslynnwu jameslynnwu enabled auto-merge (squash) March 10, 2026 19:37
@jameslynnwu jameslynnwu merged commit 6fcb5f5 into main Mar 10, 2026
24 of 25 checks passed
@jameslynnwu jameslynnwu deleted the remove-root branch March 10, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants