chore(sidekick): default rustls provider changed#3727
Conversation
With the update to `reqwest` 0.13 we had to change the default `rustls` crypto provider from `ring` to `aws-lc-rs`. This changes the generated documentation to match.
There was a problem hiding this comment.
Code Review
This pull request updates documentation and configuration templates to reflect the change of the default rustls crypto provider from ring to aws-lc-rs. The changes are consistent across the Cargo.toml.mustache, README.md.mustache, and lib.rs.mustache template files. The updates correctly change the provider names and also update the function path for installing a crypto provider to rustls::crypto::CryptoProvider::install_default(), which is accurate given recent changes in the rustls crate. The changes are correct and well-contained.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
=======================================
Coverage 82.33% 82.33%
=======================================
Files 138 138
Lines 12739 12739
=======================================
Hits 10489 10489
Misses 1774 1774
Partials 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With the update to
reqwest0.13 we had to change the defaultrustlscrypto provider fromringtoaws-lc-rs. This changes the generated documentation to match.Part of the work for googleapis/google-cloud-rust#4367