feat(sidekick): Generate setter samples for repeated and map fields#2368
Merged
amanda-tarafa merged 4 commits intogoogleapis:mainfrom Sep 25, 2025
Merged
feat(sidekick): Generate setter samples for repeated and map fields#2368amanda-tarafa merged 4 commits intogoogleapis:mainfrom
amanda-tarafa merged 4 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2368 +/- ##
=======================================
Coverage 84.25% 84.25%
=======================================
Files 98 98
Lines 9922 9922
=======================================
Hits 8360 8360
Misses 1212 1212
Partials 350 350 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Accompaniying PR: googleapis/google-cloud-rust#3409 @coryan and reviewers, a couple of notes around maps:
|
Contributor
The other specs are more restrictive than Protobuf, so far, only strings.
👍 |
coryan
requested changes
Sep 25, 2025
Contributor
coryan
left a comment
There was a problem hiding this comment.
A few minor improvements. Otherwise looks great.
internal/sidekick/internal/rust/templates/common/setter_preamble/repeated.mustache
Outdated
Show resolved
Hide resolved
internal/sidekick/internal/rust/templates/common/setter_preamble/map.mustache
Outdated
Show resolved
Hide resolved
internal/sidekick/internal/rust/templates/common/setter_preamble/map.mustache
Show resolved
Hide resolved
internal/sidekick/internal/rust/templates/common/setter_preamble/map.mustache
Outdated
Show resolved
Hide resolved
2e94e10 to
d899de0
Compare
amanda-tarafa
commented
Sep 25, 2025
Contributor
Author
amanda-tarafa
left a comment
There was a problem hiding this comment.
Change requests addressed on latest commit.
internal/sidekick/internal/rust/templates/common/setter_preamble/map.mustache
Show resolved
Hide resolved
internal/sidekick/internal/rust/templates/common/setter_preamble/map.mustache
Outdated
Show resolved
Hide resolved
internal/sidekick/internal/rust/templates/common/setter_preamble/map.mustache
Outdated
Show resolved
Hide resolved
internal/sidekick/internal/rust/templates/common/setter_preamble/repeated.mustache
Outdated
Show resolved
Hide resolved
coryan
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.