Skip to content

feat(sidekick): Generate setter samples for repeated and map fields#2368

Merged
amanda-tarafa merged 4 commits intogoogleapis:mainfrom
amanda-tarafa:setter-samples
Sep 25, 2025
Merged

feat(sidekick): Generate setter samples for repeated and map fields#2368
amanda-tarafa merged 4 commits intogoogleapis:mainfrom
amanda-tarafa:setter-samples

Conversation

@amanda-tarafa
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.25%. Comparing base (c9e1cdc) to head (d899de0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2368   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files          98       98           
  Lines        9922     9922           
=======================================
  Hits         8360     8360           
  Misses       1212     1212           
  Partials      350      350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amanda-tarafa
Copy link
Copy Markdown
Contributor Author

Accompaniying PR: googleapis/google-cloud-rust#3409

@coryan and reviewers, a couple of notes around maps:

  • Samples for maps are as supported by protobuf, that is, keys are only strings, integers-like including bool. I'm not sure if the other specs that we are/ will be supporting allow for other key types. I'm happy to add more cases.
  • I've added samples for a map with bool keys, that's unlikely to be ever used, but it's allowed, so...

@coryan
Copy link
Copy Markdown
Contributor

coryan commented Sep 25, 2025

  • Samples for maps are as supported by protobuf, that is, keys are only strings, integers-like including bool. I'm not sure if the other specs that we are/ will be supporting allow for other key types. I'm happy to add more cases.

The other specs are more restrictive than Protobuf, so far, only strings.

  • I've added samples for a map with bool keys, that's unlikely to be ever used, but it's allowed, so...

👍

Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor improvements. Otherwise looks great.

Copy link
Copy Markdown
Contributor Author

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requests addressed on latest commit.

@amanda-tarafa amanda-tarafa merged commit 2ff8248 into googleapis:main Sep 25, 2025
6 checks passed
@amanda-tarafa amanda-tarafa deleted the setter-samples branch September 25, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants