Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

test: specify correct path when running native-image test#856

Merged
suztomo merged 6 commits intogoogleapis:mainfrom
suztomo:fix_graalvm_native-test
Mar 25, 2022
Merged

test: specify correct path when running native-image test#856
suztomo merged 6 commits intogoogleapis:mainfrom
suztomo:fix_graalvm_native-test

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Mar 25, 2022 •
edited
Loading

Cont of #754

@suztomo suztomo requested a review from a team March 25, 2022 16:03
@product-auto-label product-auto-label bot added the api: vision Issues related to the googleapis/java-vision API. label Mar 25, 2022
@suztomo suztomo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 25, 2022
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Mar 25, 2022 •
edited
Loading

"Kokoro - Test: Integration" showed:

[INFO] Running com.google.cloud.vision.it.ITSystemTest
user.dir: /tmpfs/src/github/java-vision/google-cloud-vision
File('.').getAbsolutePath: /tmpfs/src/github/java-vision/google-cloud-vision/.
...

"Kokoro - Test: Java GraalVM Native Image" fails after showing different value:

[INFO] Executing: /tmpfs/src/github/java-vision/google-cloud-vision/target/native-tests --xml-output-dir /tmpfs/src/github/java-vision/google-cloud-vision/target/native-test-reports
JUnit Platform on Native Image - report
----------------------------------------

user.dir: /tmpfs/src/github/java-vision
File('.').getAbsolutePath: /tmpfs/src/github/java-vision/.
...

@suztomo suztomo mentioned this pull request Mar 25, 2022
Closed
@suztomo suztomo added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022
@suztomo suztomo requested a review from mpeddada1 March 25, 2022 21:08
@suztomo suztomo changed the title test: debugging the working directory location test: specify correct path when running native-image test Mar 25, 2022
@mpeddada1
Copy link
Copy Markdown
Contributor

mpeddada1 commented Mar 25, 2022

Learned something new here! I think it's worth documenting in the onboarding doc that Native image compilation treats getAbsolutePath() differently.

@suztomo suztomo merged commit 3ee1478 into googleapis:main Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: vision Issues related to the googleapis/java-vision API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suztomo @mpeddada1