This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix: Check generation for nullability before incrementing it#888
Merged
BenWhitehead merged 2 commits intogoogleapis:mainfrom Apr 20, 2022
Merged
fix: Check generation for nullability before incrementing it#888BenWhitehead merged 2 commits intogoogleapis:mainfrom
BenWhitehead merged 2 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
BenWhitehead
approved these changes
Apr 19, 2022
Contributor
Author
|
Hey, @BenWhitehead, am I doing something wrong? Why clirr is failing? |
Collaborator
|
@domrde I'm not sure why it's failing. It looks like some transient failure downloading jars during the build. I've manually ran clirr against this PR and verified it does not error. I'll merge shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #886 ☕️