This repository was archived by the owner on Apr 2, 2026. It is now read-only.
fix: add precondition to delete operations#1240
Merged
BenWhitehead merged 2 commits intomainfrom Aug 17, 2023
Merged
Conversation
user project on get
Contributor
sydney-munro
left a comment
There was a problem hiding this comment.
LGTM, can we get test coverage for it?
Collaborator
Author
|
The integration test suite actually already covers the various branches, because the branches are duplicated for the requester pays below it, and getting an object is always idempotent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.