Skip to content
This repository was archived by the owner on Apr 2, 2026. It is now read-only.

feat: Store bucket name in URI authority#1219

Merged
BenWhitehead merged 1 commit intogoogleapis:mainfrom
broadinstitute:bucket_uri_authority
Jul 20, 2023
Merged

feat: Store bucket name in URI authority#1219
BenWhitehead merged 1 commit intogoogleapis:mainfrom
broadinstitute:bucket_uri_authority

Conversation

@lbergelson
Copy link
Copy Markdown
Contributor

@lbergelson lbergelson commented Jul 14, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1218 ☕️

@lbergelson lbergelson requested a review from a team July 14, 2023 17:54
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 14, 2023
@google-cla
Copy link
Copy Markdown

google-cla bot commented Jul 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Jul 14, 2023
@lbergelson lbergelson changed the title Store bucket name in URI authority feat: Store bucket name in URI authority Jul 14, 2023
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf bot commented Jul 14, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@kshakir kshakir mentioned this pull request Jul 18, 2023
Closed
BenWhitehead
BenWhitehead approved these changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, and the new tests!

@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2023
@BenWhitehead BenWhitehead merged commit 99179e8 into googleapis:main Jul 20, 2023
@release-please release-please bot mentioned this pull request Jul 20, 2023
Merged
@lbergelson
Copy link
Copy Markdown
Contributor Author

lbergelson commented Jul 21, 2023

Great, thank you!

@lbergelson lbergelson deleted the bucket_uri_authority branch July 21, 2023 19:06
@release-please release-please bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage-nio API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CloudStorageFileSystem: java.net.URISyntaxException: Illegal character in hostname

3 participants

@lbergelson @BenWhitehead @yoshi-kokoro