Skip to content
This repository was archived by the owner on Apr 2, 2026. It is now read-only.

feat: FileSystemProvider::readAttributes for basic and gcs views#1066

Merged
BenWhitehead merged 2 commits intogoogleapis:mainfrom
nielsbasjes:ReadAttributes
Dec 5, 2022
Merged

feat: FileSystemProvider::readAttributes for basic and gcs views#1066
BenWhitehead merged 2 commits intogoogleapis:mainfrom
nielsbasjes:ReadAttributes

Conversation

@nielsbasjes
Copy link
Copy Markdown
Contributor

@nielsbasjes nielsbasjes commented Dec 3, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1062 ☕️

@nielsbasjes nielsbasjes requested a review from a team December 3, 2022 20:31
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage-nio API. labels Dec 3, 2022
@nielsbasjes nielsbasjes mentioned this pull request Dec 5, 2022
Merged
4 tasks
@BenWhitehead BenWhitehead added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2022
BenWhitehead
BenWhitehead approved these changes Dec 5, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

Our bot ran our code formatter, which is why this may look slightly different from what you submitted.

@BenWhitehead BenWhitehead merged commit 2f13792 into googleapis:main Dec 5, 2022
@release-please release-please bot mentioned this pull request Dec 5, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage-nio API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Java Storage NIO: FileSystemProvider::checkAccess fails on '/' with StorageException

3 participants

@nielsbasjes @BenWhitehead @yoshi-kokoro